I wouldn't move kNoExtraICState to IC unless you can remove it fully from
Code.
As we discussed, either keep it in Code or move it out as a global.
https://codereview.chromium.org/91803003/diff/20001/src/ic.h
File src/ic.h (left):
https://codereview.chromium.org/91803003/diff/20001/src/ic.h#oldcode568
src/ic.h:568: virtual StrictModeFlag strict_mode() const { return
strict_mode_; }
I guess you can make this nonvirtual now, and remove the other copies?
https://codereview.chromium.org/91803003/diff/20001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/91803003/diff/20001/src/stub-cache.cc#newcode454
src/stub-cache.cc:454: ? CONTEXTUAL : NOT_CONTEXTUAL);
nit: indent by 4 extra spaces
https://codereview.chromium.org/91803003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
