Hi Toon,
Okay, comments addressed. The big change though here is moving ExtraICState
to a
standalone definition outside of the Code class. This solves some thorny
dependency issues. It's a big renaming but I support it on the grounds that
ownership of the field is more firmly in the IC camp this way.
https://codereview.chromium.org/91803003/diff/20001/src/ic.h
File src/ic.h (left):
https://codereview.chromium.org/91803003/diff/20001/src/ic.h#oldcode568
src/ic.h:568: virtual StrictModeFlag strict_mode() const { return
strict_mode_; }
On 2013/11/28 09:58:47, Toon Verwaest wrote:
I guess you can make this nonvirtual now, and remove the other copies?
Done, and that caused a ripple into the stub compiler, where a method
that was passed strict_mode now accepts ExtraICState, then decoding that
state only when it knows it has a STORE_IC and needs to inquire about
strict mode.
https://codereview.chromium.org/91803003/diff/20001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/91803003/diff/20001/src/stub-cache.cc#newcode454
src/stub-cache.cc:454: ? CONTEXTUAL : NOT_CONTEXTUAL);
On 2013/11/28 09:58:47, Toon Verwaest wrote:
nit: indent by 4 extra spaces
Fixed in both places.
https://codereview.chromium.org/91803003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
