lgtm with nits.
https://codereview.chromium.org/91963003/diff/60001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://codereview.chromium.org/91963003/diff/60001/src/arm/stub-cache-arm.cc#newcode2104
src/arm/stub-cache-arm.cc:2104:
GenerateCallFunction(Handle<Object>::null(), function);
Consider introducing different function for such a "no-patch" version of
a call.
https://codereview.chromium.org/91963003/diff/60001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/91963003/diff/60001/src/stub-cache.cc#newcode1142
src/stub-cache.cc:1142: void
CallStubCompiler::GenerateCallFunction(Handle<Object> object,
What about name like GenerateTailCallFunction() or
GenerateJumpFunction()?
https://codereview.chromium.org/91963003/diff/60001/src/stub-cache.cc#newcode1151
src/stub-cache.cc:1151: void
CallStubCompiler::GenerateCallFunction(Handle<Object> object,
Same suggestion about name as above.
https://codereview.chromium.org/91963003/diff/60001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/91963003/diff/60001/src/x64/macro-assembler-x64.cc#newcode3613
src/x64/macro-assembler-x64.cc:3613: movq(rdx, FieldOperand(rdi,
JSFunction::kCodeEntryOffset));
rdi -> function?
https://codereview.chromium.org/91963003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
