Addressed feedback. Landing.
https://codereview.chromium.org/91963003/diff/60001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://codereview.chromium.org/91963003/diff/60001/src/arm/stub-cache-arm.cc#newcode2104
src/arm/stub-cache-arm.cc:2104:
GenerateCallFunction(Handle<Object>::null(), function);
On 2013/11/28 13:06:08, Igor Sheludko wrote:
Consider introducing different function for such a "no-patch" version
of a call.
Done.
https://codereview.chromium.org/91963003/diff/60001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/91963003/diff/60001/src/stub-cache.cc#newcode1142
src/stub-cache.cc:1142: void
CallStubCompiler::GenerateCallFunction(Handle<Object> object,
On 2013/11/28 13:06:08, Igor Sheludko wrote:
What about name like GenerateTailCallFunction() or
GenerateJumpFunction()?
Done.
https://codereview.chromium.org/91963003/diff/60001/src/stub-cache.cc#newcode1151
src/stub-cache.cc:1151: void
CallStubCompiler::GenerateCallFunction(Handle<Object> object,
On 2013/11/28 13:06:08, Igor Sheludko wrote:
Same suggestion about name as above.
Done.
https://codereview.chromium.org/91963003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
