Reviewers: Hannes Payer, mvstanton,
Message:
Hey Hannes, Michael,
This is the necessary BinaryOpIC refactoring. Based on this CL, we can add
additional stubs to the BinaryOpIC, also supporting trampolines that setup
allocation sites.
The interesting part of this CL is the new BinaryOpIC::State class, which
encapsulates all state of a BinaryOpIC and can be used by all stubs,
handlers
and trampolines that may be used by the BinaryOpIC.
There's still some open refactoring (i.e. fixing some of Andreas TODOs wrt
BinaryOps, but that's not critical right now).
PTAL
-- Benedikt
Description:
Refactor BinaryOpIC to be able to use different stubs.
Previously BinaryOpIC and BinaryOpStub were pretty much interdependent.
However, in order to use allocation sites for string adds on-demand,
we need to be able to use different stubs (with a different number of
register parameters, via trampolines) depending on the BinaryOpIC state.
Please review this at https://codereview.chromium.org/97543002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+656, -742 lines):
M src/arm/code-stubs-arm.cc
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/code-stubs-hydrogen.cc
M src/code-stubs.h
M src/code-stubs.cc
M src/ia32/code-stubs-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/ic.h
M src/ic.cc
M src/isolate.cc
M src/log.cc
M src/token.h
M src/type-info.cc
M src/x64/code-stubs-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
