Looking good. More macros / lists would probably reduce some of the code.
Also we probably should keep contextual/strict unlinked: allow both
non-strict+contextual and strict+contextual; even if it's not visible from
javascript.
https://codereview.chromium.org/96083005/diff/60001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/96083005/diff/60001/src/builtins.cc#newcode1320
src/builtins.cc:1320: }
Please, as discussed, just generate these definitions using macros.
https://codereview.chromium.org/96083005/diff/60001/src/builtins.h
File src/builtins.h (right):
https://codereview.chromium.org/96083005/diff/60001/src/builtins.h#newcode139
src/builtins.h:139: IC::kContextualState) \
Generate using macros.
https://codereview.chromium.org/96083005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
