Hi Toon,
Thanks for the comments, I've
1) used macros in builtins[.h/.cc] to reduce verbosity.
2) made sure that contextual and strictmode are treated separately. So for
example we can have a StoreIC that is contextual but not strict mode.
3) Added a test where I take call, load and store ics through some states to
make sure the state bits with contextual are transferred correctly.
4) An assert in set_target() for StoreIC that the contextual bits as well as
strict mode bits are properly propagated.
Thanks, I'll let you have a first look then address the platform ports.
--Michael
https://codereview.chromium.org/96083005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.