https://codereview.chromium.org/98993002/diff/40001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/98993002/diff/40001/src/d8.cc#newcode51
src/d8.cc:51: #include <utility>
On 2013/12/02 15:34:10, Michael Starzinger wrote:
nit: Can we move this up to the other system includes (i.e. line 42)
and
alpha-sort that block?
Nope, the presubmit check insists on this order: C headers, then C++
header, then own headers. :-P
https://codereview.chromium.org/98993002/diff/40001/src/d8.cc#newcode1107
src/d8.cc:1107: -data.GetValue()->ByteLength());
On 2013/12/02 15:34:10, Michael Starzinger wrote:
I guess there will be some casting problem between size_t and intptr_t
here on
some compiler. But we will see.
To be honest, I would prefer to see a compiler warning (if any) compared
to a silent wrong conversion. In general, our use of integral types
makes me cry, almost every API is broken, so it's hard to get the call
sites right if you have 2 wrong types for impedance matching. :-P
https://codereview.chromium.org/98993002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/98993002/diff/40001/test/cctest/test-api.cc#newcode32
test/cctest/test-api.cc:32: #include <utility>
On 2013/12/02 15:34:10, Michael Starzinger wrote:
nit: Can we alpha-sort the system includes block?
Done.
https://codereview.chromium.org/98993002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
