LGTM. Only nits.
https://codereview.chromium.org/98993002/diff/40001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/98993002/diff/40001/src/d8.cc#newcode51
src/d8.cc:51: #include <utility>
nit: Can we move this up to the other system includes (i.e. line 42) and
alpha-sort that block?
https://codereview.chromium.org/98993002/diff/40001/src/d8.cc#newcode1107
src/d8.cc:1107: -data.GetValue()->ByteLength());
I guess there will be some casting problem between size_t and intptr_t
here on some compiler. But we will see.
https://codereview.chromium.org/98993002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/98993002/diff/40001/test/cctest/test-api.cc#newcode32
test/cctest/test-api.cc:32: #include <utility>
nit: Can we alpha-sort the system includes block?
https://codereview.chromium.org/98993002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
