https://chromiumcodereview.appspot.com/101733002/diff/20001/test/cctest/test-object-observe.cc
File test/cctest/test-object-observe.cc (left):
https://chromiumcodereview.appspot.com/101733002/diff/20001/test/cctest/test-object-observe.cc#oldcode262
test/cctest/test-object-observe.cc:262:
CHECK(inner_global->StrictEquals(CompileRun("records[1].object")));
Seems like we still want to have a test for what happens if you cause a
mutation to the global (via, e.g., a closure); we want to make sure
Object.observe doesn't leak the global object in ChangeRecord.object.
Can you at least leave a TODO here to test that case (if adding such a
test now is too burdensome)?
https://chromiumcodereview.appspot.com/101733002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
