LGTM with nit.
In the future we probably want to remove the global-receiver/global-proxy
and
global-object/global-context distinction...
https://chromiumcodereview.appspot.com/101733002/diff/80001/src/api.cc
File src/api.cc (right):
https://chromiumcodereview.appspot.com/101733002/diff/80001/src/api.cc#newcode5416
src/api.cc:5416: global)->IsDetachedFrom(context->global_object())) {
That's weird indentation, what about
if (i::Handle<i::JSGlobalProxy>::cast(global)->IsDetachedFrom(
context->global_object())) {
or just
i::Handle<i::JSGlobalProxy> global_proxy =
i::Handle<i::JSGlobalProxy>::cast(global);
if (global_proxy->IsDetachedFrom(context->global_object())) {
https://chromiumcodereview.appspot.com/101733002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
