LGTM with a nit.
https://codereview.chromium.org/104583003/diff/20001/src/libplatform/default-platform.cc
File src/libplatform/default-platform.cc (right):
https://codereview.chromium.org/104583003/diff/20001/src/libplatform/default-platform.cc#newcode87
src/libplatform/default-platform.cc:87: thread_pool_size_ =
Max(Min(thread_pool_size_, 4), 1);
Either make it a v8 flag or make it at least a constant in
DefaultPlatform (kMaxPoolSize). Burying some magic number deep in the
implementation is not nice.
https://codereview.chromium.org/104583003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
