LGTM, just minor nits.
https://codereview.chromium.org/104583003/diff/40001/src/libplatform/default-platform.cc
File src/libplatform/default-platform.cc (right):
https://codereview.chromium.org/104583003/diff/40001/src/libplatform/default-platform.cc#newcode62
src/libplatform/default-platform.cc:62: ASSERT(thread_pool_size >= 0);
On 2013/12/09 19:04:31, jochen wrote:
On 2013/12/09 18:50:51, Hannes Payer wrote:
> What about: void DefaultPlatform::SetThreadPoolSize(int
thread_pool_size=0)
> and setting thread_pool_size_ to CPU::NumberOfProcessorsOnline() if
> thread_pool_size==0.
default parameters are forbidden by the coding style :)
CPU::NumberOfProccessorsOnline() is already used as fallback. However,
that
doesn't work in production (which is why we get the number of
ResourceConstraints - see api.cc)
OK, fine with me.
https://codereview.chromium.org/104583003/diff/40001/src/libplatform/default-platform.cc#newcode87
src/libplatform/default-platform.cc:87: thread_pool_size_ =
Max(Min(thread_pool_size_, kMaxThreadPoolSize), 1);
On 2013/12/09 19:04:31, jochen wrote:
On 2013/12/09 18:50:51, Hannes Payer wrote:
> I think this should be handled by SetThreadPoolSize.
I would have to duplicate this here for the case that
SetThreadPoolSize is never
invoked. So why bother?
OK, you could also invoke SetThreadPool size from here, but fine.
https://codereview.chromium.org/104583003/diff/40001/src/libplatform/default-platform.h
File src/libplatform/default-platform.h (right):
https://codereview.chromium.org/104583003/diff/40001/src/libplatform/default-platform.h#newcode63
src/libplatform/default-platform.h:63: static int thread_pool_size_;
On 2013/12/09 19:04:31, jochen wrote:
On 2013/12/09 18:50:51, Hannes Payer wrote:
> I don't think we can have static members here. This may be a problem
when we
> have multiple isolates per process?
there's only one default platform per process.
As discussed offline, TSAN will not like that in a build with two
isolates per process.
https://codereview.chromium.org/104583003/diff/120001/src/libplatform/task-queue.h
File src/libplatform/task-queue.h (right):
https://codereview.chromium.org/104583003/diff/120001/src/libplatform/task-queue.h#newcode49
src/libplatform/task-queue.h:49: // Appends a task to the queue. Takes
ownership.
You mean the queue takes ownership, right. Can we make that comment more
explicit?
https://codereview.chromium.org/104583003/diff/120001/test/cctest/test-libplatform.h
File test/cctest/test-libplatform.h (right):
https://codereview.chromium.org/104583003/diff/120001/test/cctest/test-libplatform.h#newcode63
test/cctest/test-libplatform.h:63:
Can we have a newline here?
https://codereview.chromium.org/104583003/diff/120001/test/cctest/test-libplatform.h#newcode71
test/cctest/test-libplatform.h:71: }
Can we have a newline here?
https://codereview.chromium.org/104583003/diff/120001/test/cctest/test-libplatform.h#newcode75
test/cctest/test-libplatform.h:75: }
Can we have a newline here?
https://codereview.chromium.org/104583003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
