Added comments.
https://codereview.chromium.org/108933002/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/108933002/diff/1/src/x64/lithium-codegen-x64.cc#newcode3074
src/x64/lithium-codegen-x64.cc:3074: int offs = FixedArray::kHeaderSize
- kHeapObjectTag;
Please write out variable names: "offset".
https://codereview.chromium.org/108933002/diff/1/src/x64/lithium-codegen-x64.cc#newcode3077
src/x64/lithium-codegen-x64.cc:3077: if (hinstr->type().IsSmi() &&
representation.IsInteger32()) {
Why check for hinstr->type().IsSmi()? You should only get to
representation.IsInteger32() if you converted a smi-load into an int32
load.
https://codereview.chromium.org/108933002/diff/1/src/x64/lithium-codegen-x64.cc#newcode3080
src/x64/lithium-codegen-x64.cc:3080: offs += kPointerSize / 2;
Isn't there a kSmiTagSize you can use? You just want to jump over the
smi-tag.
https://codereview.chromium.org/108933002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
