https://codereview.chromium.org/108933002/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/108933002/diff/1/src/x64/lithium-codegen-x64.cc#newcode3074
src/x64/lithium-codegen-x64.cc:3074: int offs = FixedArray::kHeaderSize
- kHeapObjectTag;
On 2013/12/09 13:47:23, Toon Verwaest wrote:
Please write out variable names: "offset".
Done.
https://codereview.chromium.org/108933002/diff/1/src/x64/lithium-codegen-x64.cc#newcode3077
src/x64/lithium-codegen-x64.cc:3077: if (hinstr->type().IsSmi() &&
representation.IsInteger32()) {
On 2013/12/09 13:47:23, Toon Verwaest wrote:
Why check for hinstr->type().IsSmi()? You should only get to
representation.IsInteger32() if you converted a smi-load into an int32
load.
We can't rely only on IsInteger32() case since we can get an int32
representation for external arrays. We dicussed this and decided that it
is better to check elements' kind against FAST_SMI_ELEMENTS.
https://codereview.chromium.org/108933002/diff/1/src/x64/lithium-codegen-x64.cc#newcode3080
src/x64/lithium-codegen-x64.cc:3080: offs += kPointerSize / 2;
On 2013/12/09 13:47:23, Toon Verwaest wrote:
Isn't there a kSmiTagSize you can use? You just want to jump over the
smi-tag.
kSmiTagSize is a number of bits, so we can't use it here, but I'll add
an assert instead:
STATIC_ASSERT(kSmiTagSize + kSmiShiftSize == 32);
https://codereview.chromium.org/108933002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
