LGTM with nits
https://codereview.chromium.org/111573003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (left):
https://codereview.chromium.org/111573003/diff/1/src/hydrogen.cc#oldcode9145
src/hydrogen.cc:9145: Representation combined_rep =
Representation::FromType(combined_type);
Not sure this matters, but deferring the conversion to later changes the
behaviour in the cases where the types get changed below (e.g. when
combined_type is None).
https://codereview.chromium.org/111573003/diff/1/src/typing.cc
File src/typing.cc (right):
https://codereview.chromium.org/111573003/diff/1/src/typing.cc#newcode164
src/typing.cc:164: Handle<Type> tag_type, label_type, combined_type;
Nit: please add the // Collect type feedback comment here
https://codereview.chromium.org/111573003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
