https://codereview.chromium.org/111573003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (left):
https://codereview.chromium.org/111573003/diff/1/src/hydrogen.cc#oldcode9145
src/hydrogen.cc:9145: Representation combined_rep =
Representation::FromType(combined_type);
On 2013/12/11 10:00:01, Jakob wrote:
On 2013/12/11 09:41:34, rossberg wrote:
> Not sure this matters, but deferring the conversion to later changes
the
> behaviour in the cases where the types get changed below (e.g. when
> combined_type is None).
Nope, doesn't matter.
The only change we'd do to the types is None -> Any, these get mapped
to
representations None and Tagged, respectively, which are handled in
the same
way. This is not just a brittle coincidence; it's the way the system
works.
Yes, I assumed as much. Though I still wonder why we have to change the
types to Any at all then.
https://codereview.chromium.org/111573003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
