So much cleaner; nice! Just 2 comments.
https://codereview.chromium.org/101853003/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/101853003/diff/1/src/code-stubs-hydrogen.cc#newcode1200
src/code-stubs-hydrogen.cc:1200: Representation::Smi());
Any reason why you manually set the representation to Smi? That should
be done automatically in HConstant?
https://codereview.chromium.org/101853003/diff/1/src/code-stubs-hydrogen.cc#newcode1244
src/code-stubs-hydrogen.cc:1244: slot_iterator,
graph()->GetConstant1());
Can you add STATIC_ASSERTs here that native_context_slot is the first
entry, and OSR_AST_ID is the last entry?
https://codereview.chromium.org/101853003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
