https://codereview.chromium.org/101853003/diff/40001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/101853003/diff/40001/src/mark-compact.cc#newcode1070
src/mark-compact.cc:1070: static const int kContextOffset =
SharedFunctionInfo::kContextOffset;
Duplicated constants for code shortitude below. Probably better to have
a subroutine...
https://codereview.chromium.org/101853003/diff/40001/src/mark-compact.cc#newcode1093
src/mark-compact.cc:1093: Object** context_slot =
HeapObject::RawField(code_map,
Ack, this code is horrible; can we please extract a function here?
https://codereview.chromium.org/101853003/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/101853003/diff/40001/src/objects.cc#newcode9643
src/objects.cc:9643: code_map->set(i + kContextOffset,
Why not an inner loop over entry length somehow?
https://codereview.chromium.org/101853003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
