Revision: 18319
Author:   [email protected]
Date:     Tue Dec 17 09:09:55 2013 UTC
Log:      Fix NotifyStubFailureSaveDoubles generation for ia32.

[email protected]

Review URL: https://chromiumcodereview.appspot.com/112833002
http://code.google.com/p/v8/source/detail?r=18319

Modified:
 /branches/bleeding_edge/src/arguments.cc
 /branches/bleeding_edge/src/ia32/builtins-ia32.cc

=======================================
--- /branches/bleeding_edge/src/arguments.cc    Fri Nov 22 10:21:47 2013 UTC
+++ /branches/bleeding_edge/src/arguments.cc    Tue Dec 17 09:09:55 2013 UTC
@@ -120,6 +120,7 @@
 double ClobberDoubleRegisters(double x1, double x2, double x3, double x4) {
// TODO(ulan): This clobbers only subset of registers depending on compiler,
   // Rewrite this in assembly to really clobber all registers.
+  // GCC for ia32 uses the FPU and does not touch XMM registers.
   return x1 * 1.01 + x2 * 2.02 + x3 * 3.03 + x4 * 4.04;
 }

=======================================
--- /branches/bleeding_edge/src/ia32/builtins-ia32.cc Thu Dec 5 16:17:44 2013 UTC +++ /branches/bleeding_edge/src/ia32/builtins-ia32.cc Tue Dec 17 09:09:55 2013 UTC
@@ -627,7 +627,12 @@


void Builtins::Generate_NotifyStubFailureSaveDoubles(MacroAssembler* masm) {
-  Generate_NotifyStubFailureHelper(masm, kSaveFPRegs);
+  if (Serializer::enabled()) {
+    PlatformFeatureScope sse2(SSE2);
+    Generate_NotifyStubFailureHelper(masm, kSaveFPRegs);
+  } else {
+    Generate_NotifyStubFailureHelper(masm, kSaveFPRegs);
+  }
 }


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to