lgtm,
Pretty amazing wizardry, thanks C++!
https://codereview.chromium.org/107933005/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/107933005/diff/1/src/ic.cc#newcode1012
src/ic.cc:1012: ? Type::Constant(Handle<JSGlobalObject>::cast(object),
isolate)
Side question: It's weird the type of the global object is itself. Why?
https://codereview.chromium.org/107933005/diff/1/src/list.h
File src/list.h (right):
https://codereview.chromium.org/107933005/diff/1/src/list.h#newcode212
src/list.h:212: typedef List<Map*> MapList;
I find it weird that these typedefs are already in the general header.
Why?
https://codereview.chromium.org/107933005/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/107933005/diff/1/src/objects.h#newcode884
src/objects.h:884: // C++ is a pile of garbage with no proper
compositionality or abstraction.
Agree with the sentiment--and glad to have a comment explaining why--
but vitriol should be limited to code review comments, you
____-_______ing ____er :)
https://codereview.chromium.org/107933005/diff/1/src/property-details.h
File src/property-details.h (right):
https://codereview.chromium.org/107933005/diff/1/src/property-details.h#newcode60
src/property-details.h:60: typedef TypeImpl<HeapTypeConfig> Type;
Oh, it spreads. Love.
https://codereview.chromium.org/107933005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
