https://codereview.chromium.org/107933005/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/107933005/diff/1/src/ic.cc#newcode1012
src/ic.cc:1012: ? Type::Constant(Handle<JSGlobalObject>::cast(object),
isolate)
On 2013/12/17 09:13:07, titzer wrote:
Side question: It's weird the type of the global object is itself.
Why?
The global object is handled rather specially in the ICs, and you need
to know its identity. Toon can explain the details.
https://codereview.chromium.org/107933005/diff/1/src/list.h
File src/list.h (right):
https://codereview.chromium.org/107933005/diff/1/src/list.h#newcode212
src/list.h:212: typedef List<Map*> MapList;
On 2013/12/17 09:13:07, titzer wrote:
I find it weird that these typedefs are already in the general header.
Why?
I don't think that they belong here either. Care to clean up? ;)
https://codereview.chromium.org/107933005/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/107933005/diff/1/src/objects.h#newcode884
src/objects.h:884: // C++ is a pile of garbage with no proper
compositionality or abstraction.
On 2013/12/17 09:13:07, titzer wrote:
Agree with the sentiment--and glad to have a comment explaining why--
but
vitriol should be limited to code review comments, you ____-_______ing
____er :)
Had to vent. I literally wasted a day trying to find a way that avoids
this abstraction leak all over the place. AFAICT, there is none.
Removed the latter half of the comment.
https://codereview.chromium.org/107933005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
