https://codereview.chromium.org/108503004/diff/20001/src/elements-kind.h
File src/elements-kind.h (right):
https://codereview.chromium.org/108503004/diff/20001/src/elements-kind.h#newcode170
src/elements-kind.h:170: inline bool
IsFastPackedSmiElementsKind(ElementsKind kind) {
I wouldn't add this method. Just directly compare with
FAST_SMI_ELEMENTS.
https://codereview.chromium.org/108503004/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/108503004/diff/20001/src/hydrogen.cc#newcode2115
src/hydrogen.cc:2115:
spurious whitespace addition
https://codereview.chromium.org/108503004/diff/20001/src/hydrogen.cc#newcode2280
src/hydrogen.cc:2280: if (IsFastPackedSmiElementsKind(elements_kind)) {
store->set_store_to_initialize_element(elements_kind ==
FAST_SMI_ELEMENTS);
https://codereview.chromium.org/108503004/diff/20001/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
https://codereview.chromium.org/108503004/diff/20001/src/x64/lithium-x64.cc#newcode2201
src/x64/lithium-x64.cc:2201: object =
UseRegisterAtStart(instr->elements());
None of the variables here should probably be "AtStart". AtStart means:
// Lifetime of operand inside the instruction.
enum Lifetime {
// USED_AT_START operand is guaranteed to be live only at
// instruction start. Register allocator is free to assign the same
register
// to some other operand used inside instruction (i.e. temporary or
// output).
USED_AT_START,
Given that you also use temps, this may make the register allocator give
you the same register for both the "AtStart" registers and the temp
registers.
https://codereview.chromium.org/108503004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
