I think I found a better/cleaner way to implement this optimization, PTAL
patch
set 4.
https://codereview.chromium.org/108503004/diff/20001/src/elements-kind.h
File src/elements-kind.h (right):
https://codereview.chromium.org/108503004/diff/20001/src/elements-kind.h#newcode170
src/elements-kind.h:170: inline bool
IsFastPackedSmiElementsKind(ElementsKind kind) {
On 2013/12/17 13:53:04, Toon Verwaest wrote:
I wouldn't add this method. Just directly compare with
FAST_SMI_ELEMENTS.
Done.
https://codereview.chromium.org/108503004/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/108503004/diff/20001/src/hydrogen.cc#newcode2115
src/hydrogen.cc:2115:
On 2013/12/17 13:53:04, Toon Verwaest wrote:
spurious whitespace addition
Done.
https://codereview.chromium.org/108503004/diff/20001/src/hydrogen.cc#newcode2280
src/hydrogen.cc:2280: if (IsFastPackedSmiElementsKind(elements_kind)) {
On 2013/12/17 13:53:04, Toon Verwaest wrote:
store->set_store_to_initialize_element(elements_kind ==
FAST_SMI_ELEMENTS);
Done.
https://codereview.chromium.org/108503004/diff/20001/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
https://codereview.chromium.org/108503004/diff/20001/src/x64/lithium-x64.cc#newcode2201
src/x64/lithium-x64.cc:2201: object =
UseRegisterAtStart(instr->elements());
We discussed the "AtStart" issue and decided that since this comment
concerns all the other places where we use "AtStart" methods there
should be a different "cleanup" CL fixing that.
https://codereview.chromium.org/108503004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
