https://codereview.chromium.org/117353002/diff/1/test/cctest/profiler-extension.cc
File test/cctest/profiler-extension.cc (right):
https://codereview.chromium.org/117353002/diff/1/test/cctest/profiler-extension.cc#newcode60
test/cctest/profiler-extension.cc:60:
v8::String::NewFromUtf8(args.GetIsolate(), ""));
Will v8::String::Empty() work here?
https://codereview.chromium.org/117353002/diff/1/test/cctest/profiler-extension.cc#newcode71
test/cctest/profiler-extension.cc:71:
v8::String::NewFromUtf8(args.GetIsolate(), ""));
ditto
https://codereview.chromium.org/117353002/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/117353002/diff/1/test/cctest/test-cpu-profiler.cc#newcode380
test/cctest/test-cpu-profiler.cc:380:
const_cast<v8::CpuProfile*>(p2)->Delete();
What's ProfilerExtension::last_profile at this point?
https://codereview.chromium.org/117353002/diff/1/test/cctest/test-cpu-profiler.cc#newcode385
test/cctest/test-cpu-profiler.cc:385: CHECK_EQ(0,
iprofiler->GetProfilesCount());
Mind to check here that ProfilerExtension::last_profile is NULL? ;-)
https://codereview.chromium.org/117353002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
