https://codereview.chromium.org/117353002/diff/1/test/cctest/profiler-extension.cc
File test/cctest/profiler-extension.cc (right):
https://codereview.chromium.org/117353002/diff/1/test/cctest/profiler-extension.cc#newcode60
test/cctest/profiler-extension.cc:60:
v8::String::NewFromUtf8(args.GetIsolate(), ""));
On 2013/12/17 16:20:17, alph wrote:
Will v8::String::Empty() work here?
Done.
https://codereview.chromium.org/117353002/diff/1/test/cctest/profiler-extension.cc#newcode60
test/cctest/profiler-extension.cc:60:
v8::String::NewFromUtf8(args.GetIsolate(), ""));
On 2013/12/18 06:48:21, Sven Panne wrote:
On 2013/12/17 16:20:17, alph wrote:
> Will v8::String::Empty() work here?
Heads up: Although this is not explicitly deprecated, we're about to
remove
*all* deprecated stuff + some more things. Empty() without an Isolate*
parameter
is about to die, too. In general, use an Isolate version if there is
one.
Switched to the method with Isolate* parameter.
https://codereview.chromium.org/117353002/diff/1/test/cctest/profiler-extension.cc#newcode71
test/cctest/profiler-extension.cc:71:
v8::String::NewFromUtf8(args.GetIsolate(), ""));
On 2013/12/17 16:20:17, alph wrote:
ditto
Done.
https://codereview.chromium.org/117353002/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/117353002/diff/1/test/cctest/test-cpu-profiler.cc#newcode380
test/cctest/test-cpu-profiler.cc:380:
const_cast<v8::CpuProfile*>(p2)->Delete();
On 2013/12/17 16:20:17, alph wrote:
What's ProfilerExtension::last_profile at this point?
I don't care as ProfilerExtension::last_profile is a way to get result
of ProfilerExtension::stopProfiling method right after it was invoked.
It is up to the test to make sure that it calls it in appropriate
moment.
https://codereview.chromium.org/117353002/diff/1/test/cctest/test-cpu-profiler.cc#newcode385
test/cctest/test-cpu-profiler.cc:385: CHECK_EQ(0,
iprofiler->GetProfilesCount());
On 2013/12/17 16:20:17, alph wrote:
Mind to check here that ProfilerExtension::last_profile is NULL? ;-)
Why should I? We didn't use ProfilerExtension here and last_profile is a
convenience field for accessing profiles started from the script.
https://codereview.chromium.org/117353002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
