Reviewers: dcarney,
https://codereview.chromium.org/111613003/diff/160001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/111613003/diff/160001/src/bootstrapper.cc#newcode2613
src/bootstrapper.cc:2613: native_context()->global_proxy());
I think we should only be doing this if we are deserializing the
snapshot. Basically it should be done around the time we do
HookUpInnerGlobal.
https://codereview.chromium.org/111613003/diff/160001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/111613003/diff/160001/src/hydrogen.cc#newcode7735
src/hydrogen.cc:7735:
expr->target()->context()->global_object()->global_receiver());
context()->global_proxy()
Weren't you planning on extracting this to a separate method?
https://codereview.chromium.org/111613003/diff/160001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/111613003/diff/160001/src/stub-cache.cc#newcode1155
src/stub-cache.cc:1155: FetchGlobalProxy(masm(), function, rdx);
EEK! rdx in src/stub-cache.cc?
Please run tests on all platforms ;)
https://codereview.chromium.org/111613003/diff/160001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/111613003/diff/160001/src/x64/builtins-x64.cc#newcode830
src/x64/builtins-x64.cc:830: CallStubCompiler::FetchGlobalProxy(masm,
rdi, rbx);
Maybe we should swap the arguments in FetchGlobalProxy, to have the
target on the left and the source on the right, as in most
assembler-related functions. Otherwise someone is guaranteed to swap
them. (Probably me...)
Description:
Load the global proxy from the context of the target function.
BUG=
Please review this at https://codereview.chromium.org/111613003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+309, -84 lines):
M src/arm/ic-arm.cc
M src/arm/stub-cache-arm.cc
M src/bootstrapper.cc
M src/code-stubs.h
M src/hydrogen-instructions.h
M src/hydrogen.cc
M src/ia32/ic-ia32.cc
M src/ia32/stub-cache-ia32.cc
M src/runtime.cc
M src/runtime.js
M src/stub-cache.h
M src/stub-cache.cc
M src/v8globals.h
M src/x64/builtins-x64.cc
M src/x64/code-stubs-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/ic-x64.cc
M src/x64/lithium-codegen-x64.cc
M src/x64/stub-cache-x64.cc
M test/cctest/test-api.cc
A test/mjsunit/contextual-calls.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
