Hey Toon, I hope you can land this before I get back. I've added a few
comments
that it would be great if you could incorporate before landing.
https://codereview.chromium.org/111613003/diff/280001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
https://codereview.chromium.org/111613003/diff/280001/src/arm/builtins-arm.cc#newcode1078
src/arm/builtins-arm.cc:1078: __ ldr(r2, ContextOperand(cp,
Context::GLOBAL_OBJECT_INDEX));
here and below we load from the correct context directly. for the other
architectures, we're loading from the function via FetchGlobalProxy, but
the function isn't any more in a register here. maybe the other arches
should be like this one?
https://codereview.chromium.org/111613003/diff/280001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/111613003/diff/280001/src/ia32/code-stubs-ia32.cc#newcode2533
src/ia32/code-stubs-ia32.cc:2533: __ mov(ecx, GlobalObjectOperand());
this should have a TODO to fix for function proxies
https://codereview.chromium.org/111613003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
