On 2013/12/20 10:15:40, jochen wrote:
On 2013/12/18 12:49:54, Paweł Hajdan Jr. wrote:
> Drive-by.
>
> https://codereview.chromium.org/77913003/diff/1/include/v8.h
> File include/v8.h (left):
>
> https://codereview.chromium.org/77913003/diff/1/include/v8.h#oldcode5544
> include/v8.h:5544: V8_INLINE static void SetEmbedderData(v8::Isolate*
isolate,
> void* data) {
> Shouldn't there be V8_DEPRECATED SetEmbedderData(v8::Isolate* isolate,
void*
> data)?
>
> Looks like this CL removes that signature without deprecating it first.
>
> Is it possible to have a reasonable implementation of this, or does it
just
have
> to be removed without deprecation?
I'm not sure I understand your comment?
I think this CL breaks API in a backward-incompatible way, and doesn't use
V8_DEPRECATED to keep the old interface for at least one release.
https://codereview.chromium.org/77913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
