https://codereview.chromium.org/116533003/diff/120001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/116533003/diff/120001/src/runtime.cc#newcode5815
src/runtime.cc:5815: RUNTIME_ASSERT(names->get(j)->IsString());
I don't think these asserts are necessary, but the correct assert would
be IsName(), since this function supports returning symbols as well as
strings. also, an ASSERT would make more sense here
https://codereview.chromium.org/116533003/diff/120001/src/runtime.cc#newcode5818
src/runtime.cc:5818: if (!names->get(k)->IsTheHole() &&
no need for a hole check here, see last comment
https://codereview.chromium.org/116533003/diff/120001/src/runtime.cc#newcode5822
src/runtime.cc:5822: if (name_from_hidden_proto->Equals(name)) {
all Name keys for properties are either symbols or internalized strings,
so Equals is overkill there, can just use == and merge the above if
clause to make
name_from_hidden_proto == names->get(k) &&
isolate->heap()->hidden_string() != names->get(k)
https://codereview.chromium.org/116533003/diff/120001/src/runtime.cc#newcode5842
src/runtime.cc:5842: if (proto_with_hidden_properties > 0 || duplicates
0) {
maybe merge these 2 variables into a single duplicate_properties
variable
https://codereview.chromium.org/116533003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
