lgtm, if the comments below are addressed
https://codereview.chromium.org/116533003/diff/180001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/116533003/diff/180001/src/runtime.cc#newcode5815
src/runtime.cc:5815: String* name_from_hidden_proto =
String::cast(names->get(j));
You can't cast to String here. It would have to be Name, but in this
case, there's no need to cast whatsoever. Just use Object*
https://codereview.chromium.org/116533003/diff/180001/src/runtime.cc#newcode5818
src/runtime.cc:5818: String* name = String::cast(names->get(k));
same here
https://codereview.chromium.org/116533003/diff/180001/src/runtime.cc#newcode5846
src/runtime.cc:5846: if (name == isolate->heap()->hidden_string())
continue;
would you please add a hidden_strings-- here and an ASSERT_EQ(0,
hidden_strings) after the loop. It will be a good check that
bookkeeping is correct in case of future changes to this logic
https://codereview.chromium.org/116533003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
