Just as "heads up" in case you missed it, I think in line 406 of current
master
src/v8natives.js you left the poison in place.
I believe it should not be there so ...
- set: desc.getSet() === ObjectSetProto ? ObjectPoisonProto
- : desc.getSet(),
+ set: desc.getSet(),
Even if exposed, the poison was throwing in my previous and incomplete
patch I
had to drop that completely in order to make it work as expected.
In case your changes avoid such problem, then never mind this comment.
https://codereview.chromium.org/141913002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
