Looking good, just agreed with your new macro idea + asking for a bit more
tests
https://codereview.chromium.org/141913002/diff/1/src/v8natives.js
File src/v8natives.js (right):
https://codereview.chromium.org/141913002/diff/1/src/v8natives.js#newcode1020
src/v8natives.js:1020: if (IS_NULL_OR_UNDEFINED(obj) &&
!IS_UNDETECTABLE(obj)) {
On 2014/01/17 17:43:23, arv wrote:
The ES6 spec uses CheckObjectCoercible. It comes up in a few places so
maybe we
should add new macro for this?
CHECK_OBJECT_COERCIBLE(obj, 'Object.setPrototypeOf')
which would throw the required type error.
Agreed, good idea.
https://codereview.chromium.org/141913002/diff/1/test/mjsunit/set-prototype-of.js
File test/mjsunit/set-prototype-of.js (right):
https://codereview.chromium.org/141913002/diff/1/test/mjsunit/set-prototype-of.js#newcode31
test/mjsunit/set-prototype-of.js:31: function getObjects() {
Maybe more tests to check that slots from new prototype participate in
look-up, while the slots from the old prototype do not
https://codereview.chromium.org/141913002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
