Hi Toon, cupla questions.
--Michael
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc#newcode4459
src/ia32/code-stubs-ia32.cc:4459: __ j(greater,
&attempt_to_grow_elements);
Could you write the !FLAG_inline_new case here, such that you go to
label call_builtin, otherwise label attempt_to_grow_elements. This way
it's symmetrical with the else (double) case, and avoids a duplicate
TailCallExternalReference statement.
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc#newcode4505
src/ia32/code-stubs-ia32.cc:4505: masm, DONT_TRACK_ALLOCATION_SITE,
NULL);
Do we know that the array passed in is from the current native context?
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc#newcode4546
src/ia32/code-stubs-ia32.cc:4546: const int kAllocationDelta = 4;
ASSERT(kAllocationDelta >= argc);
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc#newcode4571
src/ia32/code-stubs-ia32.cc:4571: // We know the elements array is in
new space so we don't need the
How do we know the elements array is in new space?
https://codereview.chromium.org/143213003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
