https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc#newcode4505
src/ia32/code-stubs-ia32.cc:4505: masm, DONT_TRACK_ALLOCATION_SITE,
NULL);
Good catch. We currently don't.
On 2014/01/20 14:49:13, mvstanton wrote:
Do we know that the array passed in is from the current native
context?
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc#newcode4546
src/ia32/code-stubs-ia32.cc:4546: const int kAllocationDelta = 4;
On 2014/01/20 14:49:13, mvstanton wrote:
ASSERT(kAllocationDelta >= argc);
Done.
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc#newcode4571
src/ia32/code-stubs-ia32.cc:4571: // We know the elements array is in
new space so we don't need the
Line 4541 (etc.) checks that. It would have gone to the builtin if it
wasn't at the end of newspace.
On 2014/01/20 14:49:13, mvstanton wrote:
How do we know the elements array is in new space?
https://codereview.chromium.org/143213003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
