Nice cleanup! lgtm
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#newcode417
src/x64/stub-cache-x64.cc:417: Handle<Map>
Handle<Map> prototype_map(
JSObject::cast(current_map->prototype())->map());
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#newcode426
src/x64/stub-cache-x64.cc:426: CHECK(false);
UNREACHABLE();
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#newcode703
src/x64/stub-cache-x64.cc:703: api_receiver,
Handle<JSObject>(lookup->holder()));
This entire code part is a bit weird to me. Why would we have an
interceptor case if there's a holder above the interceptor? Or that just
because the holder is completely unrelated to the thing that holds the
API function? Is that why you called it api_holder?
https://codereview.chromium.org/142973005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
