Reviewers: Toon Verwaest,
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#newcode703
src/x64/stub-cache-x64.cc:703: api_receiver,
Handle<JSObject>(lookup->holder()));
On 2014/01/20 19:11:09, Toon Verwaest wrote:
This entire code part is a bit weird to me. Why would we have an
interceptor
case if there's a holder above the interceptor? Or that just because
the holder
is completely unrelated to the thing that holds the API function? Is
that why
you called it api_holder?
exactly. It's not what you'd expect to call a holder, but it's between
the receiver and the holder on the chain. it would be nice to delete
all this garbage with recursive interceptors
Description:
Unify calling to GenerateFastApiCallBody before stubbing it
[email protected]
BUG=
Please review this at https://codereview.chromium.org/142973005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+120, -206 lines):
M src/stub-cache.h
M src/stub-cache.cc
M src/x64/stub-cache-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
