The code could be optimized with ldp/stp for the state but since this code
will
disappear, it is not worth spending the time.
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-a64.cc
File src/a64/lithium-a64.cc (right):
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-a64.cc#newcode1256
src/a64/lithium-a64.cc:1256: return MarkAsCall(DefineFixedDouble(result,
d7), instr);
Use d0 to be consistent with other uses.
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc#newcode3560
src/a64/lithium-codegen-a64.cc:3560: // Having marked this instruction
as a call we can use any registers.
ASSERT(instr->IsMarkedAsCall());
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc#newcode3578
src/a64/lithium-codegen-a64.cc:3578: __ cbz(w2, deferred->entry());
cbz -> Cbz
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc#newcode3583
src/a64/lithium-codegen-a64.cc:3583: __ And(w4, w2, Operand(0xFFFF));
No need for Operand, And(w4, 0xFFFF) works.
This applies to mov and and below too.
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc#newcode3602
src/a64/lithium-codegen-a64.cc:3602: __ bind(deferred->exit());
bind -> Bind
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc#newcode3610
src/a64/lithium-codegen-a64.cc:3610: __
CallCFunction(ExternalReference::random_uint32_function(isolate()), 0);
the function takes a parameter.
https://codereview.chromium.org/145693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
