On 2014/01/24 15:13:38, Rodolph Perfetta wrote:
On 2014/01/24 06:37:52, Benedikt Meurer wrote:
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc
> File src/a64/lithium-codegen-a64.cc (right):
>
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc#newcode3578
> src/a64/lithium-codegen-a64.cc:3578: __ cbz(w2, deferred->entry());
> On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > cbz -> Cbz
>
> Done.
>
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc#newcode3583
> src/a64/lithium-codegen-a64.cc:3583: __ And(w4, w2, Operand(0xFFFF));
> On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > No need for Operand, And(w4, 0xFFFF) works.
> >
> > This applies to mov and and below too.
>
> Done.
>
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc#newcode3602
> src/a64/lithium-codegen-a64.cc:3602: __ bind(deferred->exit());
> On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > bind -> Bind
>
> Done.
>
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc#newcode3610
> src/a64/lithium-codegen-a64.cc:3610: __
> CallCFunction(ExternalReference::random_uint32_function(isolate()), 0);
> On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > the function takes a parameter.
>
> Done.
The diff is empty, can you re upload.
Should be fine now, although the incremental diff seems to be broken
(Rietvield
*arg*).
https://codereview.chromium.org/145693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
