First round of comments, in addition to offline chatting.
https://codereview.chromium.org/137403009/diff/480001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/137403009/diff/480001/src/ast.cc#newcode727
src/ast.cc:727: if (CallFeedbackSlot() >= 0) {
!= kInvalidFeedbackSlot
https://codereview.chromium.org/137403009/diff/480001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/137403009/diff/480001/src/ast.h#newcode197
src/ast.h:197: maximum_feedback_slots_ += maximum;
Can we have an ASSERT here to make sure that minimum_feedback_slots_ <=
maximum_feedback_slots_?
https://codereview.chromium.org/137403009/diff/480001/src/ast.h#newcode967
src/ast.h:967: first_feedback_slot_(0),
Initialize to -1 as below. Extra points if you add some
kInvalidFeedbackSlotIndex constant for this purpose.
https://codereview.chromium.org/137403009/diff/480001/src/ast.h#newcode1849
src/ast.h:1849: first_feedback_slot_(-1),
Remember the extra points...? ;-)
https://codereview.chromium.org/137403009/diff/480001/src/ast.h#newcode1909
src/ast.h:1909: first_feedback_slot_(0),
See above.
https://codereview.chromium.org/137403009/diff/480001/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/137403009/diff/480001/src/full-codegen.cc#newcode395
src/full-codegen.cc:395: feedback_vector_ =
isolate->factory()->NewFixedArrayWithHoles(minimum_length,
As discussed offline: Please add an explanation here, that we have to do
this for now because of our parser.
https://codereview.chromium.org/137403009/diff/480001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/137403009/diff/480001/src/ia32/code-stubs-ia32.cc#newcode5814
src/ia32/code-stubs-ia32.cc:5814:
Add an AssertIsSmi(edx).
https://codereview.chromium.org/137403009/diff/480001/src/ia32/code-stubs-ia32.cc#newcode5821
src/ia32/code-stubs-ia32.cc:5821: // TODO(mvstanton): change this
message below.
Please fix this TODO.
https://codereview.chromium.org/137403009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
