LGTM if question and nit below is addressed.
https://codereview.chromium.org/137403009/diff/1000001/src/feedback_slots.h
File src/feedback_slots.h (right):
https://codereview.chromium.org/137403009/diff/1000001/src/feedback_slots.h#newcode52
src/feedback_slots.h:52: virtual int GetFeedbackSlotCount(Isolate*
isolate) = 0;
Nit: Rename to ComputeFeedbackSlotCount().
https://codereview.chromium.org/137403009/diff/1000001/src/type-info.cc
File src/type-info.cc (right):
https://codereview.chromium.org/137403009/diff/1000001/src/type-info.cc#newcode88
src/type-info.cc:88: return
Handle<Object>::cast(isolate()->factory()->undefined_value());
Hm, now we return uninitialized if there's no concrete value in the
slot, but undefined if it's a JSFunction that can retain another
context. Is that intended? If so we should document this.
https://codereview.chromium.org/137403009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
