lgtm
https://codereview.chromium.org/145353003/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (left):
https://codereview.chromium.org/145353003/diff/1/src/heap-snapshot-generator.cc#oldcode1120
src/heap-snapshot-generator.cc:1120: SetWeakReference(js_fun, entry, i,
*HeapObject::RawField(js_fun, i), i);
Please add STATIC_CHECK that there are no other weak fields.
https://codereview.chromium.org/145353003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
