https://codereview.chromium.org/145353003/diff/240001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/145353003/diff/240001/src/heap-snapshot-generator.cc#newcode1217
src/heap-snapshot-generator.cc:1217:
EXTRACT_CONTEXT_FIELD(OPTIMIZED_FUNCTIONS_LIST, ,
optimized_functions_list);
On 2014/01/27 01:05:29, tfarina wrote:
looks like this broke the clang build on linux x64:
$ ninja -C out/Debug/ All
....
../../src/heap-snapshot-generator.cc:1217:53: error: empty macro
arguments are a
C99 feature [-Werror,-Wc99-extensions]
EXTRACT_CONTEXT_FIELD(OPTIMIZED_FUNCTIONS_LIST, ,
optimized_functions_list);
^
../../src/heap-snapshot-generator.cc:1218:48: error: empty macro
arguments are a
C99 feature [-Werror,-Wc99-extensions]
EXTRACT_CONTEXT_FIELD(OPTIMIZED_CODE_LIST, , optimized_code_list);
^
../../src/heap-snapshot-generator.cc:1219:50: error: empty macro
arguments are a
C99 feature [-Werror,-Wc99-extensions]
EXTRACT_CONTEXT_FIELD(DEOPTIMIZED_CODE_LIST, ,
deoptimized_code_list);
^
../../src/heap-snapshot-generator.cc:1220:46: error: empty macro
arguments are a
C99 feature [-Werror,-Wc99-extensions]
EXTRACT_CONTEXT_FIELD(NEXT_CONTEXT_LINK, , next_context_link);
^
4 errors generated.
$ clang++ --version
clang version 3.5 (trunk 198389)
Target: x86_64-unknown-linux-gnu
Thread model: posix
Strange, I also use clang and it compiles just fine for me:
$ ninja -j 1000 -C out/Debug chrome
ninja: Entering directory `out/Debug'
[13749/13749] LINK chrome
$ clang++ --version
clang version 3.5 (trunk 198389)
Target: x86_64-unknown-linux-gnu
Thread model: posix
Nevertheless, I'll add a dummy argument.
https://codereview.chromium.org/145353003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.