lgtm
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#newcode65
test/cctest/cctest.status:65: test-api/ExternalArrays: SKIP
Maybe 'PASS || TIMEOUT' instead of 'SKIP'? That could catch some
crashes.
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#newcode71
test/cctest/cctest.status:71: test-api/ExternalDoubleArray: SKIP
Did *Array tests finish on your machine?
https://codereview.chromium.org/137543009/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):
https://codereview.chromium.org/137543009/diff/1/test/mjsunit/mjsunit.status#newcode133
test/mjsunit/mjsunit.status:133: array-sort: SKIP
Maybe 'PASS, (PASS || TIMEOUT) if $mode == debug' instead of 'SKIP'?
That could catch some crashes.
https://codereview.chromium.org/137543009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
