https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#newcode65
test/cctest/cctest.status:65: test-api/ExternalArrays: SKIP
On 2014/01/28 12:13:23, ulan wrote:
Maybe 'PASS || TIMEOUT' instead of 'SKIP'? That could catch some
crashes.
Done.
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#newcode71
test/cctest/cctest.status:71: test-api/ExternalDoubleArray: SKIP
On 2014/01/28 12:25:38, ulan wrote:
On 2014/01/28 12:13:23, ulan wrote:
> Did *Array tests finish on your machine?
I ran test-api/ExternalArrays and it finishes in ~20 minutes, so it
should be OK
to skip these tests.
Yes I tested all of these, and they take ~17 minutes on my machine.
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#newcode75
test/cctest/cctest.status:75: test-api/Fload32Array: SKIP
On 2014/01/28 12:28:46, Jakob wrote:
s/Fload/Float/ or this won't do what you want ;-)
Done.
https://codereview.chromium.org/137543009/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):
https://codereview.chromium.org/137543009/diff/1/test/mjsunit/mjsunit.status#newcode133
test/mjsunit/mjsunit.status:133: array-sort: SKIP
On 2014/01/28 12:13:23, ulan wrote:
Maybe 'PASS, (PASS || TIMEOUT) if $mode == debug' instead of 'SKIP'?
That could
catch some crashes.
Done.
https://codereview.chromium.org/137543009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
