More fine-grained conditional test expectations seem to be all the rage
these
days, and for the record, I don't like that trend. If at all possible, the
test
runner should always run the same tests and always in the same way; anything
else is a slippery slope to chaos and madness.
Since in this case I don't see an obvious alternative other than always
skipping
this test (or at least those parts of it that exceed the stack), I'm
approving
this CL, but I'd like to emphasize that I'm seeing this as a temporary
solution.
LGTM with the comments below.
https://codereview.chromium.org/139233005/diff/1/test/webkit/webkit.status
File test/webkit/webkit.status (right):
https://codereview.chromium.org/139233005/diff/1/test/webkit/webkit.status#newcode45
test/webkit/webkit.status:45: ['sim == True', {
Please call the variable 'simulator'. Also, you can skip the '== True'
part.
https://codereview.chromium.org/139233005/diff/1/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/139233005/diff/1/tools/run-tests.py#newcode409
tools/run-tests.py:409: variables["sim"] = True
Overwriting this after the fact is confusing. Please move computation of
the value to before the "variables" dictionary is created, then in line
400 set it immediately to its final value (essentially, treat
"variables" as a read-only object).
https://codereview.chromium.org/139233005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
