On 2014/01/30 15:58:25, Paul Lind wrote:
Hi Jakob - I'm afraid I don't see this as temporary, given large change to
simulator to fix this properly (see
http://code.google.com/p/v8/issues/detail?id=3124).
Well, yeah. Ideally the simulator should be as close to real hardware as
possible, especially for simulating error conditions. Then again this does
seem
to be a pretty big change, and I'm not sure it's worth it. I haven't looked
closely; maybe there's a reasonably easy way to catch stack overflows at
some
choke point at the simulator <-> runtime boundary.
Another approach would be to change the test. How much value do the three
calls
that cause RangeErrors provide? Maybe we can just remove them. Or we could
split
the test into two tests: one that always runs everywhere (with the
succeeding
calls), one that's skipped entirely for simulator-using architectures.
The alternative is to skip
this CL, and stop running webkits tests on the simulator. You guys don't
run
ARM
sim on this suite, at least on your public bots.
I've noticed that too today, and it surprised me. We should probably add the
webkit tests to one of the ARM simulator bots.
(we run both hw & sim.) Would you prefer we don't land this?
I've said LGTM to express "it's OK to land this". Thanks for asking, though.
https://codereview.chromium.org/139233005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
