Just a small comment
https://codereview.chromium.org/136333011/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/136333011/diff/1/src/objects-inl.h#newcode3684
src/objects-inl.h:3684: this,
FixedTypedArray<Float64ArrayTraits>::SizeFor(index));
I am not too happy with using SizeFor here - it does not convey the
intent, although it does do the right thing. Could you add an
ElementOffset function to FixedTypedArray, and use it here?
https://codereview.chromium.org/136333011/diff/1/src/objects-inl.h#newcode3702
src/objects-inl.h:3702: this,
FixedTypedArray<Float64ArrayTraits>::SizeFor(index), value);
Ditto
https://codereview.chromium.org/136333011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
