On 2014/01/30 18:34:03, Dmitry Lomov (chromium) wrote:
A small nit
https://codereview.chromium.org/136333011/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/136333011/diff/20001/src/objects.h#newcode4903
src/objects.h:4903: return SizeFor(index);
Please express them the other way round, i.e. SizeFor(index) is
meanint SizeFor(length) of course.
ElementOffset(length). In that way, if we decide in the future to stick
more
stuff at the end of FixedTypedArray, ElementOffset won't be affected.
https://codereview.chromium.org/136333011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
