I think there are still some misunderstandings. I think the equality is
wrong.
https://codereview.chromium.org/118553003/diff/170001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/118553003/diff/170001/src/messages.js#newcode184
src/messages.js:184: symbol_to_string: ["Cannot convert
Symbol values to strings"],
"value to string" maybe?
https://codereview.chromium.org/118553003/diff/170001/src/messages.js#newcode186
src/messages.js:186: symbol_to_primitive: ["Cannot convert
Symbol wrapper objects to primitive values"],
same?
https://codereview.chromium.org/118553003/diff/170001/test/mjsunit/harmony/symbols.js
File test/mjsunit/harmony/symbols.js (right):
https://codereview.chromium.org/118553003/diff/170001/test/mjsunit/harmony/symbols.js#newcode45
test/mjsunit/harmony/symbols.js:45: function IndirectSymbol() { return
Symbol() }
Should be lower case now since it is not a constructor.
https://codereview.chromium.org/118553003/diff/170001/test/mjsunit/harmony/symbols.js#newcode172
test/mjsunit/harmony/symbols.js:172: assertEquals(Object(symbols[i]),
Object(symbols[i]))
This looks strange. If symbol[i] is a symbol (not a symbol wrapper) then
this should be false. Are all elements in symbols wrappers? It does not
seem like that is the case on line 49.
https://codereview.chromium.org/118553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
